You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates pyproject.toml to be compatible with poetry, although I have omitted the .lock file to make this more general.
Notes:
poetry does not currently conform to PEP 621, so the format currently differs from most other modern pyproject.toml files, although support will be implemented in the next major release.
We cannot use dynamic versioning with this, so now need to specify the version both in pyproject.toml and init.py
Updates will be needed to replace the build/publishing, but these will be in a separate pull request
This also updates the workflows to use poetry installations where possible, bumps actions versions in workflows, and bumps dev (formerly testing) versions in pyproject.toml.
This will need rebasing once #58 is merged. I may also drop Python 3.12 back down to 3.11, as discussed with @alinelena, to minimise compatibility issues with janus(-core)
@ElliottKasoar i think some disconnect happened between the ci duplication removal pr #58 and this one... so practically your ci_orig changes need to be ported to ci.yaml... once done is mergeable
The reason will be displayed to describe this comment to others. Learn more.
Looks fine beyond that clarification for me. Though can you still install this e.g. through pip without poetry? Because for most people that's probably more convenient.
Looks fine beyond that clarification for me. Though can you still install this e.g. through pip without poetry? Because for most people that's probably more convenient.
Assuming you mean pip installing the repository, pip install . will install the main dependencies (under [tool.poetry.dependencies]), but I don't think [docs] etc. works for the other grouped dependencies, which I suspect is the consequence of the current misalignment with other formats.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElliottKasoar
force-pushed
the
add-poetry
branch
from
Resolves #45 and #50
Updates pyproject.toml to be compatible with poetry, although I have omitted the .lock file to make this more general.
Notes:
This also updates the workflows to use poetry installations where possible, bumps
actionsversions in workflows, and bumpsdev(formerlytesting) versions in pyproject.toml.To do: